Fix a crash of the report suites override section. #405
Conversation
I initially thought about adding a test. But we wouldn't test any workflow. I am not sure if it is worth it so I decided to not do it. I tested manually all the other fields in the section. Report suites failed, because you can define more than one. |
dompuiu
force-pushed
the
fix_report_suite_overrides
branch
from
6aecee0
to
93fecb3
Compare
| .max(60, "The Main Ping Interval must be less than 60 seconds.") | ||
| .default(10), | ||
| }), | ||
| adPingInterval: lazy((value) => |
There was a problem hiding this comment.
If you know a better way to make a field accept the number or an empty string, please let me know.
| @@ -33,7 +33,7 @@ const FormikNumberField = ({ name, width, validate, ...otherProps }) => { | |||
| return ( | |||
| <NumberField | |||
| {...otherProps} | |||
| value={value} | |||
| value={value === "" ? null : value} | |||
There was a problem hiding this comment.
If you provide an empty string to a Spectrum Number Field, it automatically converts that to 0. For keeping it empty, you need to provide a null value.
Formik on the other hand it, will complain if you initialize a field with null and change the field value at a later point. A warning appears in logs where it says a component was changed from uncontrolled to controlled.
That is what I added this change.
| @@ -327,6 +327,8 @@ const createExtensionManifest = ({ version }) => { | |||
| type: "integer", | |||
| }, | |||
| }, | |||
| required: ["channel", "playerName"], | |||
There was a problem hiding this comment.
Schema was to relaxed. You could have saved an object without channel or playerName. You could have saved also other properties that were not defined.
| getInitialInstanceValues: ({ instanceSettings }) => { | ||
| if (!instanceSettings.streamingMedia) { | ||
| instanceSettings.streamingMedia = getDefaultSettings(); | ||
| return bridge.getInstanceDefaults(); |
There was a problem hiding this comment.
The extension configuration was crashing because the instanceSettings was returned. The instance settings was containing keys that could potentially override other bridge method from different sections. We need to return an object that contains just the streamingMedia key.
| getInstanceSettings: ({ instanceValues }) => { | ||
| const instanceSettings = {}; | ||
| const { streamingMedia } = instanceValues; | ||
|
|
||
| ["appVersion", "adPingInterval", "mainPingInterval"].forEach((key) => { | ||
| if (!streamingMedia[key]) { |
There was a problem hiding this comment.
Here I clear the empty values of optional fields. Before, they were saved to the DB.
Description
Fix a crash of the report suites override section. Niklas from Scania reported this on the Measure slack channel.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: